-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cases] Cases assignees sub feature #201654
[Cases] Cases assignees sub feature #201654
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
I just updated the labels on this PR. It didn't merge before the 9.0/8.18 feature freeze, and the backport to 8.x failed. Right now, this change will only be included in 9.1. I'm assuming that we'll be fixing the backport, so I added the 8.19 label. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
## Summary This pr implements a new cases assignee sub-feature, allowing users to control a role's ability to change the assignee of a case. With the permission enabled, they can assign any user to any case, with it disabled, the assignees component is hidden. Read only + enabled: ![image](https://github.com/user-attachments/assets/ba421784-d976-4ae9-a399-e404c26b3842) All + assign disabled: ![image](https://github.com/user-attachments/assets/d835b6f9-5a14-4ae0-abed-b3c3252c2692) ### Checklist - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 0e7c608) # Conflicts: # x-pack/platform/plugins/shared/cases/server/client/cases/bulk_update.test.ts # x-pack/platform/plugins/shared/features/server/__snapshots__/oss_features.test.ts.snap # x-pack/test/api_integration/apis/cases/common/roles.ts # x-pack/test/api_integration/apis/cases/common/users.ts # x-pack/test/api_integration/apis/cases/privileges.ts # x-pack/test/security_api_integration/tests/features/deprecated_features.ts # x-pack/test/spaces_api_integration/common/suites/get.ts
@kobelb I think it made it in to 9.0 bc1, but not 8.18: https://github.com/elastic/kibana/commits/fd1f8b62137f14e93716e298e4e931b576e2ca13 for 9.0 vs
I think it would be ok to include in 8.18 BC2 as long as CI passes eventually, given that it's in 9.0 already, but if anyone disagrees I can close it. |
You are correct, apologies. Added you to a slack thread where we're weighing the risk vs benefit regarding which 8.x release we are comfortable backporting this to. |
This pr implements a new cases assignee sub-feature, allowing users to control a role's ability to change the assignee of a case. With the permission enabled, they can assign any user to any case, with it disabled, the assignees component is hidden. Read only + enabled: ![image](https://github.com/user-attachments/assets/ba421784-d976-4ae9-a399-e404c26b3842) All + assign disabled: ![image](https://github.com/user-attachments/assets/d835b6f9-5a14-4ae0-abed-b3c3252c2692) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <[email protected]>
This pr implements a new cases assignee sub-feature, allowing users to control a role's ability to change the assignee of a case. With the permission enabled, they can assign any user to any case, with it disabled, the assignees component is hidden. Read only + enabled: ![image](https://github.com/user-attachments/assets/ba421784-d976-4ae9-a399-e404c26b3842) All + assign disabled: ![image](https://github.com/user-attachments/assets/d835b6f9-5a14-4ae0-abed-b3c3252c2692) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <[email protected]>
This pr implements a new cases assignee sub-feature, allowing users to control a role's ability to change the assignee of a case. With the permission enabled, they can assign any user to any case, with it disabled, the assignees component is hidden. Read only + enabled: ![image](https://github.com/user-attachments/assets/ba421784-d976-4ae9-a399-e404c26b3842) All + assign disabled: ![image](https://github.com/user-attachments/assets/d835b6f9-5a14-4ae0-abed-b3c3252c2692) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <[email protected]>
This pr implements a new cases assignee sub-feature, allowing users to control a role's ability to change the assignee of a case. With the permission enabled, they can assign any user to any case, with it disabled, the assignees component is hidden. Read only + enabled: ![image](https://github.com/user-attachments/assets/ba421784-d976-4ae9-a399-e404c26b3842) All + assign disabled: ![image](https://github.com/user-attachments/assets/d835b6f9-5a14-4ae0-abed-b3c3252c2692) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <[email protected]>
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
# Backport This will backport the following commits from `main` to `8.x`: - [[Cases] Cases assignees sub feature (#201654)](#201654) - [[Cases] Fix an issue with the reopen case permission, add integration tests for failing case (#201517)](#201517) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kevin Qualters","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-30T16:04:38Z","message":"[Cases] Cases assignees sub feature (#201654)\n\n## Summary\r\n\r\nThis pr implements a new cases assignee sub-feature, allowing users to\r\ncontrol a role's ability to change the assignee of a case. With the\r\npermission enabled, they can assign any user to any case, with it\r\ndisabled, the assignees component is hidden.\r\n\r\nRead only + enabled:\r\n\r\n![image](https://github.com/user-attachments/assets/ba421784-d976-4ae9-a399-e404c26b3842)\r\n\r\n\r\nAll + assign disabled:\r\n\r\n![image](https://github.com/user-attachments/assets/d835b6f9-5a14-4ae0-abed-b3c3252c2692)\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"0e7c608ed3d62852b72eaf45e65e347a03bd08d6","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:ResponseOps","backport missing","release_note:feature","Team:Threat Hunting:Investigations","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v9.1.0","v8.19.0"],"title":"[Cases] Cases assignees sub feature","number":201654,"url":"https://github.com/elastic/kibana/pull/201654","mergeCommit":{"message":"[Cases] Cases assignees sub feature (#201654)\n\n## Summary\r\n\r\nThis pr implements a new cases assignee sub-feature, allowing users to\r\ncontrol a role's ability to change the assignee of a case. With the\r\npermission enabled, they can assign any user to any case, with it\r\ndisabled, the assignees component is hidden.\r\n\r\nRead only + enabled:\r\n\r\n![image](https://github.com/user-attachments/assets/ba421784-d976-4ae9-a399-e404c26b3842)\r\n\r\n\r\nAll + assign disabled:\r\n\r\n![image](https://github.com/user-attachments/assets/d835b6f9-5a14-4ae0-abed-b3c3252c2692)\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"0e7c608ed3d62852b72eaf45e65e347a03bd08d6"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"url":"https://github.com/elastic/kibana/pull/209435","number":209435,"branch":"8.18","state":"OPEN"}]}] BACKPORT--> --------- Co-authored-by: Elastic Machine <[email protected]>
# Backport This will backport the following commits from `main` to `8.18`: - [[Cases] Cases assignees sub feature (#201654)](#201654) - [[Cases] Fix an issue with the reopen case permission, add integration tests for failing case (#201517)](#201517) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kevin Qualters","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-30T16:04:38Z","message":"[Cases] Cases assignees sub feature (#201654)\n\n## Summary\r\n\r\nThis pr implements a new cases assignee sub-feature, allowing users to\r\ncontrol a role's ability to change the assignee of a case. With the\r\npermission enabled, they can assign any user to any case, with it\r\ndisabled, the assignees component is hidden.\r\n\r\nRead only + enabled:\r\n\r\n![image](https://github.com/user-attachments/assets/ba421784-d976-4ae9-a399-e404c26b3842)\r\n\r\n\r\nAll + assign disabled:\r\n\r\n![image](https://github.com/user-attachments/assets/d835b6f9-5a14-4ae0-abed-b3c3252c2692)\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"0e7c608ed3d62852b72eaf45e65e347a03bd08d6","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:ResponseOps","v9.0.0","release_note:feature","Team:Threat Hunting:Investigations","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.18.0"],"title":"[Cases] Cases assignees sub feature","number":201654,"url":"https://github.com/elastic/kibana/pull/201654","mergeCommit":{"message":"[Cases] Cases assignees sub feature (#201654)\n\n## Summary\r\n\r\nThis pr implements a new cases assignee sub-feature, allowing users to\r\ncontrol a role's ability to change the assignee of a case. With the\r\npermission enabled, they can assign any user to any case, with it\r\ndisabled, the assignees component is hidden.\r\n\r\nRead only + enabled:\r\n\r\n![image](https://github.com/user-attachments/assets/ba421784-d976-4ae9-a399-e404c26b3842)\r\n\r\n\r\nAll + assign disabled:\r\n\r\n![image](https://github.com/user-attachments/assets/d835b6f9-5a14-4ae0-abed-b3c3252c2692)\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"0e7c608ed3d62852b72eaf45e65e347a03bd08d6"}},"sourceBranch":"main","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201654","number":201654,"mergeCommit":{"message":"[Cases] Cases assignees sub feature (#201654)\n\n## Summary\r\n\r\nThis pr implements a new cases assignee sub-feature, allowing users to\r\ncontrol a role's ability to change the assignee of a case. With the\r\npermission enabled, they can assign any user to any case, with it\r\ndisabled, the assignees component is hidden.\r\n\r\nRead only + enabled:\r\n\r\n![image](https://github.com/user-attachments/assets/ba421784-d976-4ae9-a399-e404c26b3842)\r\n\r\n\r\nAll + assign disabled:\r\n\r\n![image](https://github.com/user-attachments/assets/d835b6f9-5a14-4ae0-abed-b3c3252c2692)\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"0e7c608ed3d62852b72eaf45e65e347a03bd08d6"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Elastic Machine <[email protected]>
Summary
This pr implements a new cases assignee sub-feature, allowing users to control a role's ability to change the assignee of a case. With the permission enabled, they can assign any user to any case, with it disabled, the assignees component is hidden.
Read only + enabled:
![image](https://private-user-images.githubusercontent.com/56408403/395342327-ba421784-d976-4ae9-a399-e404c26b3842.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxODQ2NzksIm5iZiI6MTczOTE4NDM3OSwicGF0aCI6Ii81NjQwODQwMy8zOTUzNDIzMjctYmE0MjE3ODQtZDk3Ni00YWU5LWEzOTktZTQwNGMyNmIzODQyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDEwNDYxOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRjMTZlMzlhNzgwOTViOTkwZDIwYmI4Y2NiZGVjNzE1NGEyOTE1NjQyNjcwMzAxMDEzN2Y3ZGMxYzZmMjg1OWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0._RJpNpxdJRci3XYZzrRtFT8fVTj9NYMiaGjoIya4ULA)
All + assign disabled:
![image](https://private-user-images.githubusercontent.com/56408403/395342195-d835b6f9-5a14-4ae0-abed-b3c3252c2692.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxODQ2NzksIm5iZiI6MTczOTE4NDM3OSwicGF0aCI6Ii81NjQwODQwMy8zOTUzNDIxOTUtZDgzNWI2ZjktNWExNC00YWUwLWFiZWQtYjNjMzI1MmMyNjkyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDEwNDYxOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc2YThlNDMxODcxOTAzYTY4MDAzN2FmNTc4NmJjZjA3MDcwODY1NTQzMGM5MjIzNjM1NTZiZDE5MzBhYmVlMDcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.hm1A8ESQWvlOuAOkVJ2HgR_QHBMZaEQ5xbZFaj_Zl2c)
Checklist